Grimoire BGM issue (in the Easter Eggs Mansion)

[YNagato]

The "Promise" in the Grimoire is preceded by BGM "hope."

But in EP5, the BGM should be "dir."

The atmosphere is subtly different. May we change it back to "dir" in Grimoire?

[vit9696]

I am trying to follow What do you mean in particular?

[YNagato]

In the original EP5 scene, the background music right before the song "Promise" is "dir."

Even though the same scene is reproduced in Grimoire (in the Easter Eggs Mansion), the background music right before the "Promise" becomes "Hope" instead of "dir," because "Hope" is the background music inside the whole Easter Eggs Mansion. But I believe the background music should have changed to "dir" once we click a door to play that particular EP5 scene.

The atmosphere of the whole scene in Grimoire now becomes different. And there is also no differentiation in terms of music between the inside and outside of the scene, since the Mansion's BGM continues into the scene. I was therefore suggesting making a minor change to switch the background music to "dir" when we click the door in Grimoire to enter that scene.

I hope this time I explain myself more clearly?

[vit9696]

Yeah, it is more clear now. You could have just mentioned the labels o8_0/omakeeee_m1f_p1br_door to make it obvious. Maybe replace

Code: Select all

*omakeeee_m1f_p1br_door
csp_rst
bg black,0
vol_mix_fade 1000
flush 2
wait 500
goto *o8_0
goto *omakeeee_m1f_p1br_loop

with

Code: Select all

*omakeeee_m1f_p1br_door
csp_rst
bg black,0
vol_mix_fade 1000
vol_bgm -1,1000
flush 2
wait 500
bgmplay 106,90,0
wait 500
goto *o8_0
goto *omakeeee_m1f_p1br_loop

Will that feel right?

[YNagato]

That's great! Thanks for making the change.

(I reported as a layman this time, without discussing it with my teammate programmers, so I failed to refer to the code. Sorry...)

[vit9696]

I did not make this change in the repository, but if it works for you, please commit.

[YNagato]

Committed. Thanks!